Skip to content

feat: Notify customers if newer submitter is available.#274

Merged
karthikbekalp merged 4 commits intoaws-deadline:mainlinefrom
karthikbekalp:updateDialogp
Apr 17, 2026
Merged

feat: Notify customers if newer submitter is available.#274
karthikbekalp merged 4 commits intoaws-deadline:mainlinefrom
karthikbekalp:updateDialogp

Conversation

@karthikbekalp
Copy link
Copy Markdown
Contributor

@karthikbekalp karthikbekalp commented Mar 31, 2026

DO NOT MERGE UNTIL aws-deadline/deadline-cloud#1070 is released in Deadline Cloud

What was the problem/requirement? (What/Why)

Customers are not aware if they are working on the latest submitter or not.

What was the solution? (How)

Created a new dialog to suggest customers to update their submitter.

What is the impact of this change?

Customers hopefully have the latest submitter always or at least are notified of this.

How was this change tested?

image image

If customers want to deactivate the feature, they can do it in the settings.

image
  • Have you run the unit tests?
    Yes

Also added a spec test.

image

Have you run a render job successfully with these changes?

No as this dialog opens even before job submission.

Was this change documented?

Yes added it into setup-submitter if customers want to deactivate the feature.

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@karthikbekalp karthikbekalp requested a review from a team as a code owner March 31, 2026 21:13
@karthikbekalp karthikbekalp marked this pull request as draft March 31, 2026 21:13
@github-actions github-actions Bot added the waiting-on-maintainers Waiting on the maintainers to review. label Mar 31, 2026
@karthikbekalp karthikbekalp force-pushed the updateDialogp branch 5 times, most recently from 7211985 to 88b0bfb Compare March 31, 2026 21:52
@karthikbekalp karthikbekalp marked this pull request as ready for review March 31, 2026 21:53
@karthikbekalp karthikbekalp enabled auto-merge (squash) March 31, 2026 21:53
Comment thread src/unreal_plugin/Content/Python/update_check.py
Comment thread src/unreal_plugin/Content/Python/update_check.py Outdated
Comment thread src/unreal_plugin/Content/Python/update_check.py
Comment thread test/deadline_submitter_for_unreal/unit/test_update_check.py Outdated
@karthikbekalp karthikbekalp disabled auto-merge April 2, 2026 16:31
@karthikbekalp karthikbekalp marked this pull request as draft April 2, 2026 17:52
joel-wong-aws
joel-wong-aws previously approved these changes Apr 2, 2026
@Cherie-Chen Cherie-Chen removed the waiting-on-maintainers Waiting on the maintainers to review. label Apr 2, 2026
Cherie-Chen
Cherie-Chen previously approved these changes Apr 2, 2026
Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
@karthikbekalp karthikbekalp dismissed stale reviews from Cherie-Chen and joel-wong-aws via 19f37b1 April 15, 2026 20:43
@karthikbekalp karthikbekalp marked this pull request as ready for review April 15, 2026 20:43
Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
@karthikbekalp karthikbekalp enabled auto-merge (squash) April 15, 2026 20:55
@sonarqubecloud
Copy link
Copy Markdown

@karthikbekalp karthikbekalp merged commit 003ff08 into aws-deadline:mainline Apr 17, 2026
16 checks passed
@karthikbekalp karthikbekalp deleted the updateDialogp branch April 17, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants